Add support for bash completions #105
Open
+46
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @tnull as a reviewer! |
benthecarman
force-pushed
the
bash-completion
branch
from
509807b to
ed43d04
Compare
tnull
reviewed
Jan 20, 2026
ldk-server-cli/Cargo.toml
Outdated
| [dependencies] | ||
| ldk-server-client = { path = "../ldk-server-client", features = ["serde"] } | ||
| clap = { version = "4.0.5", default-features = false, features = ["derive", "std", "error-context", "suggestions", "help"] } | ||
| clap_complete = "4.0" |
Collaborator
There was a problem hiding this comment.
Can we disable default features for this?
README.md
Outdated
| ``` | ||
| ./target/debug/ldk-server-cli -b localhost:3002 --api-key your-secret-api-key onchain-receive # To generate onchain-receive address. | ||
| ./target/debug/ldk-server-cli -b localhost:3002 --api-key your-secret-api-key help # To print help/available commands. | ||
| ./target/debug/ldk-server-cli -b localhost:3002 --api-key your-secret-api-key --tls-cert /path/to/tls_cert.pem onchain-receive # To generate onchain-receive address. |
Collaborator
There was a problem hiding this comment.
Should we drop the ./target/debug/ part? That seems very Rust-dev specific, let alone that users probably want to build on release eventually.
Collaborator
Author
There was a problem hiding this comment.
yeah, removed
benthecarman
force-pushed
the
bash-completion
branch
from
ed43d04 to
cb24752
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.